Implement sub-settings methods#264
Conversation
|
I already see some logs are broken (in the rebase process I did not pay enough attention) |
|
I correct the method documentation. |
alallema
left a comment
alallema
left a comment
There was a problem hiding this comment.
Thanks, @ezienecker for this PR!
I made some suggestions.
I will open a new issue to send null to all the settings in the test see. And another to add the new methods to the .code-samples.meilisearch.yaml file except if you want to make one of them in this PR.
| * | ||
| * @param uid Index identifier | ||
| * @return ranking rules settings of a given uid as String | ||
| * @return A Map that contains all synonyms and their associated words |
There was a problem hiding this comment.
There seems to be an exchange between the description of synonyms and rankings rules
| * @return A Map that contains all synonyms and their associated words | |
| * @return an array of strings that contains the ranking rules settings |
| * https://docs.meilisearch.com/reference/api/synonyms.html#get-synonyms | ||
| * | ||
| * @param uid Index identifier | ||
| * @return ranking rules settings of a given uid as String |
There was a problem hiding this comment.
Exchange with rankings rules?
| * @return ranking rules settings of a given uid as String | |
| * @return a Map that contains all synonyms and their associated words |
| * https://docs.meilisearch.com/reference/api/stop_words.html#get-stop-words | ||
| * | ||
| * @param uid Index identifier | ||
| * @return An array of strings that contains the stop-words. |
There was a problem hiding this comment.
| * @return An array of strings that contains the stop-words. | |
| * @return an array of strings that contains the stop-words |
| * https://docs.meilisearch.com/reference/api/stop_words.html#update-stop-words | ||
| * | ||
| * @param uid Index identifier | ||
| * @param stopWords An array of strings that contains the stop-words |
There was a problem hiding this comment.
| * @param stopWords An array of strings that contains the stop-words | |
| * @param stopWords an array of strings that contains the new stop-words settings |
| * https://docs.meilisearch.com/reference/api/searchable_attributes.html#update-searchable-attributes | ||
| * | ||
| * @param uid Index identifier | ||
| * @param searchableAttributes An array of strings that contains the stop-words. |
There was a problem hiding this comment.
| * @param searchableAttributes An array of strings that contains the stop-words. | |
| * @param searchableAttributes an array of strings that contains the new searchable attributes settings |
| * https://docs.meilisearch.com/reference/api/filterable_attributes.html#get-filterable-attributes | ||
| * | ||
| * @param uid Index identifier | ||
| * @return filterable attributes settings of a given uid as String |
There was a problem hiding this comment.
| * @return filterable attributes settings of a given uid as String | |
| * @return an array of strings that contains the filterable attributes settings |
| * https://docs.meilisearch.com/reference/api/distinct_attribute.html#get-distinct-attribute | ||
| * | ||
| * @param uid Index identifier | ||
| * @return distinct attribute field of a given uid as String |
There was a problem hiding this comment.
| * @return distinct attribute field of a given uid as String | |
| * @return a string of the distinct attribute field |
| * https://docs.meilisearch.com/reference/api/synonyms.html#update-synonyms | ||
| * | ||
| * @param uid Index identifier | ||
| * @param synonyms the data that contains the new settings |
There was a problem hiding this comment.
| * @param synonyms the data that contains the new settings | |
| * @param synonyms a Map that contains the new synonyms settings |
| * https://docs.meilisearch.com/reference/api/synonyms.html#get-synonyms | ||
| * | ||
| * @param uid Index identifier | ||
| * @return ranking rules settings of a given uid as String |
There was a problem hiding this comment.
It should be the synonyms instead of rankings rules
There was a problem hiding this comment.
Can you copy the same description than in the src/main/java/com/meilisearch/sdk/SettingsHandler.java file?
| * https://docs.meilisearch.com/reference/api/synonyms.html#update-synonyms | ||
| * | ||
| * @param uid Index identifier | ||
| * @param synonyms the data that contains the new ranking rules settings |
There was a problem hiding this comment.
It should be synonyms instead of ranking rules
|
Hi @ezienecker, |
|
Hi @alallema, I have now incorporated the comments so far. Thanks for putting the hacktoberfest-accepted label ;) |
alallema
left a comment
alallema
left a comment
There was a problem hiding this comment.
LGTM!
Thanks again @ezienecker for all your PR in Meilisearch!
|
bors merge |
|
Build succeeded: |
2 participants
Implement the following sub-settings methods: