Skip to content

source-control:babysit-prs: test_pr_queue_snapshot.py integration test doesn't assert the ignored bucket for Approve-with-nits classification #578

Description

@kyle-sexton

Lane: work · Category: improvement

Triggering example

claude[bot] PR review on #567 (fix for #499 — babysit snapshot Approve-with-nits classification) surfaced one minor test-coverage gap, explicitly assessed as non-blocking ("not a correctness hole... worth a follow-up but not a blocker. Ready to merge"), deferred here rather than fixed inline.

Observed vs expected

test_pr_queue_snapshot.py's ApproveWithNitsClassification.test_approve_with_only_nits_is_not_blocking asserts material == [] and blocking == [] for the end-to-end classification path, but doesn't assert that the item actually lands in feedback["ignored"]. The unit test in test_babysit_feedback.py does cover the ignored bucket, so there's no correctness hole today — but the integration test doesn't fully encode the invariant it's meant to demonstrate. Expected: add self.assertEqual(len(result["feedback"]["ignored"]), 1) to that integration test to tighten the end-to-end assertion.

Notes

Cosmetic/coverage-scoped only; no correctness, security, or architectural concern. Full bot review: PR #567 review comment (claude[bot]).

Work-class: C3 (bug-fix-shaped) — attended triage 2026-07-23, operator-ratified. 🤖

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.priority: mediumReal value, no hard deadline; normal backlog flow.status: readyTriaged, unblocked, and fully specified; eligible to pick up.work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions