Skip to content

Conversation

@sofiapatrocinio
Copy link
Contributor

Description

Correction of Prospector errors executed under Jandig's code. You can see the full tool log here.

Resolves (Issues)

Resolve #445

General tasks performed

  • Fix user view file code violations
  • Fix user urls file code violations
  • Fix tasks file code violations
  • Fix forms file code violations
  • Fix encrypt service file code violations
  • Fix user service file code violations
  • Fix forms file code violations
  • Fix models file code violation
  • Fix email_service file code violations
  • Fix urls file code violations
  • Fix home file code violations
  • Fix factory file code violation
  • Fix settings file code violation
  • Fix wait_db file code violation
  • Fix locustfile file code violation
  • Fix makefile file code violation
  • Fix jinja2 config file code violation
  • Fix compilemessages file code violation

Have you confirmed the application builds locally without error? See here.

  • Yes

sofiapatrocinio and others added 8 commits March 9, 2022 11:55
Co-authored-by: Hugo Sobral <hugosobral10@gmail.com>
Co-authored-by: Sofia Patrocinio <sofiacpatrocinio@gmail.com>
Co-authored-by: Sofia Patrocinio <sofiacpatrocinio@gmail.com>
Co-authored-by: Hugo Sobral <hugosobral10@gmail.com>
Co-authored-by: Hugo Sobral <hugosobral10@gmail.com>
Co-authored-by: Sofia Patrocinio <sofiacpatrocinio@gmail.com>
Co-authored-by: Sofia Patrocinio <sofiacpatrocinio@gmail.com>
Co-authored-by: Sofia Patrocinio <sofiacpatrocinio@gmail.com>
Copy link
Member

@pablodiegoss pablodiegoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing code improvements here, maybe you could add a little topic on the docs on how to use prospector to find and fix stylesheet problems or python code smells?

KiSobral and others added 2 commits March 24, 2022 13:53
Co-authored-by: Sofia Patrocinio <sofiacpatrocinio@gmail.com>
Co-authored-by: Sofia Patrocinio <sofiacpatrocinio@gmail.com>
@KiSobral
Copy link
Contributor

Amazing code improvements here, maybe you could add a little topic on the docs on how to use prospector to find and fix stylesheet problems or python code smells?

@pablodiegoss We had just created a short md document about how to install and use prospector.

@pablodiegoss pablodiegoss merged commit b6966a0 into memeLab:develop Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix errors, potential problems, convention violations logged by Prospector

3 participants