Create tests for Marker API #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durvalcarvalho
approved these changes
Oct 31, 2022
Collaborator
durvalcarvalho
left a comment
durvalcarvalho
left a comment
There was a problem hiding this comment.
Well done! I ran the tests locally and they all passed correctly! Excellent work!
The only thing I noticed is that the path to the environment variables file (.env) in docker-compose.yml is incorrect. In my environment I changed it to - src/.envs/.env and it worked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mocking objects on the Jandig database was always an issue for testing, since we upload files to storage and filesystem after upload. This PR adds an in-memory storage for testing, enabling the execution of unit tests on the new API created for Markers.
General tasks performed
Have you confirmed the application builds locally without error? See here.