[REVIEW] Creating exhibit with repeated name crashes the frontend #528
Conversation
| // 54 is the length when there is no problem | ||
| if (artworkError.length != 54) { |
There was a problem hiding this comment.
Might be better if you compare directly the success string here instead of the length of the response.
Something like artworkError != "success", since using the length makes it very obscure for maintenance, I'm not even sure what text will be shown if there is no error, only that it has "54" characters.
There was a problem hiding this comment.
I was strugling to find a proper conditional and that length was the only thing that worked. I changed to check if the innerTexts have part of the error messages
| // 56 and 62 are the length when there is no problem | ||
| else if (exhibitNameError.length != 56 || exhibitSlugError.length != 62) { |
There was a problem hiding this comment.
Same thing as stated above, using the length here is a bad idea for maintenance, can we compare the strings directly?
You can create boolean variables to store the results and make it even clearer.
Eg:
noExhibitNameError = exhibitNameError != "success with 56 chars"
...
else if noExhibitNameError {
2 participants
Description
Added form validation and auto modal pop up when there is an error
Resolves (Issues)
#367
General tasks performed
Have you confirmed the application builds locally without error? See here.