Skip to content

Comments

Add error message to cypherl output#71

Merged
imilinovic merged 1 commit intomasterfrom
cypherl-output
Feb 20, 2024
Merged

Add error message to cypherl output#71
imilinovic merged 1 commit intomasterfrom
cypherl-output

Conversation

@imilinovic
Copy link
Contributor

@imilinovic imilinovic commented Feb 19, 2024

Print out error message when cypherl output format is used on non-string objects to make it more clear that it can only be used with DUMP DATABASE.
Issues:
closes #69

@imilinovic imilinovic self-assigned this Feb 19, 2024
@imilinovic imilinovic added bug bug community community labels Feb 19, 2024
@imilinovic imilinovic marked this pull request as ready for review February 19, 2024 10:36
Copy link

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine 👍. If this comment about clarifying the README is still applicable, I’ll approve once you update that.

@imilinovic
Copy link
Contributor Author

imilinovic commented Feb 19, 2024

I've created an issue and PR on the official docs to add the documentation about this, it seems the cypherl format was never documented at all and noted there that only dump database is supported. Link

@imilinovic imilinovic requested a review from antepusic February 19, 2024 20:53
Copy link

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my concern here! I can approve the PR now 🚀

@imilinovic imilinovic merged commit 8681adb into master Feb 20, 2024
@imilinovic imilinovic deleted the cypherl-output branch February 20, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug bug community community

Projects

Development

Successfully merging this pull request may close these issues.

'--output-format=cypherl' seems broken

2 participants