Skip to content

Fix: Fix multiple maps issue #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cizl merged 1 commit into from
Nov 7, 2022
Merged

Fix: Fix multiple maps issue #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/views/map-view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,11 @@ const osmAttribution =
'<a href="https://leafletjs.com/" target="_blank" >Leaflet</a> | ' +
'Map data &copy; <a href="https://www.openstreetmap.org/">OpenStreetMap</a> contributors';

const DEFAULT_MAP_TILE: ILeafletMapTile = {
instance: new L.TileLayer('https://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png'),
attribution: osmAttribution,
const getDefaultMapTile = () => {
return {
instance: new L.TileLayer('https://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png'),
attribution: osmAttribution,
};
};

const DEFAULT_ZOOM_LEVEL = 2;
Expand Down Expand Up @@ -82,7 +84,7 @@ export class MapView<N extends INodeBase, E extends IEdgeBase> implements IOrbVi
...settings,
map: {
zoomLevel: settings.map?.zoomLevel ?? DEFAULT_ZOOM_LEVEL,
tile: settings.map?.tile ?? DEFAULT_MAP_TILE,
tile: settings.map?.tile ?? getDefaultMapTile(),
},
render: {
type: RendererType.CANVAS,
Expand Down