Improve docker images and add a makefile for local builds#503
Closed
pox wants to merge 2 commits intomempool:masterfrom
Closed
Improve docker images and add a makefile for local builds#503pox wants to merge 2 commits intomempool:masterfrom
pox wants to merge 2 commits intomempool:masterfrom
Conversation
e.g. make frontend tag=1.2.3
wiz
requested changes
Jun 9, 2021
Member
wiz
left a comment
There was a problem hiding this comment.
Hi @pox - sorry for the late response. Yes, we would prefer you to copy the file from the project instead of adding it as a third party dependency to the Dockerfile. Please preserve the original copyright/license and other relevant legal notices at the top of anything you copy from that project. Also I see there is a merge conflict now, so it would be cool if you can resolve that one as well.
Thank you for fixing this!
Member
|
@knorrium since it's been over a month did you want to take over this PR ? |
Member
|
@wiz I'm going to close this PR as it has merge conflicts. we can make these improvements when introducing the other Docker changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please consider this PR a suggestion for a couple of improvements. If you like any of them, please let me know and I'll change as requested.
docker-compose downit hangs for a while (it's not forwarding signals properly. So I've added TINI. If you prefer another handler let me know. Also, if you prefer to just add TINI (it's just ashfile) to the repo, instead of downloading it from an external source, I'd be happy to do that as well.