-
Notifications
You must be signed in to change notification settings - Fork 984
Add api docs for /api/v1/fees/precise #6147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds API documentation for the new /api/v1/fees/precise endpoint, which returns fee rate recommendations with up to 3 decimal places (including sub-satoshi rates). This extends the existing fees documentation to cover the more precise variant of the fee recommendation endpoint.
Key Changes
- Added comprehensive documentation entry for the
/api/v1/fees/preciseendpoint - Included response examples for all supported networks (mainnet, testnet, signet, liquid, liquidTestnet)
| response: `{ | ||
| "fastestFee": 2.023, | ||
| "halfHourFee": 1.094, | ||
| "hourFee": 0.502, | ||
| "economyFee": 0.2, | ||
| "minimumFee": 0.1 | ||
| }` |
Copilot
AI
Dec 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The response object keys should use JavaScript object notation (unquoted keys) instead of JSON notation (quoted keys) to be consistent with other REST API endpoint examples in this file.
For example, change "fastestFee" to fastestFee, "halfHourFee" to halfHourFee, etc. This applies to all network sample responses (mainnet, testnet, signet, liquid, liquidTestnet).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sir, usage of quotes is inconsistent through the existing docs. It's more correct to include the quotes since that is the exact syntax of the response returned by the server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot you're right, please troll @hunicus more about this
Part of https://github.com/mempool/mempool.space/issues/1945.