Skip to content

Conversation

@hunicus
Copy link
Contributor

@hunicus hunicus commented Dec 5, 2025

@cla-bot cla-bot bot added the cla-signed label Dec 5, 2025
@orangesurf orangesurf added this to the v3.3.0 milestone Dec 5, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds API documentation for the new /api/v1/fees/precise endpoint, which returns fee rate recommendations with up to 3 decimal places (including sub-satoshi rates). This extends the existing fees documentation to cover the more precise variant of the fee recommendation endpoint.

Key Changes

  • Added comprehensive documentation entry for the /api/v1/fees/precise endpoint
  • Included response examples for all supported networks (mainnet, testnet, signet, liquid, liquidTestnet)

Comment on lines +7756 to +7762
response: `{
"fastestFee": 2.023,
"halfHourFee": 1.094,
"hourFee": 0.502,
"economyFee": 0.2,
"minimumFee": 0.1
}`
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The response object keys should use JavaScript object notation (unquoted keys) instead of JSON notation (quoted keys) to be consistent with other REST API endpoint examples in this file.

For example, change "fastestFee" to fastestFee, "halfHourFee" to halfHourFee, etc. This applies to all network sample responses (mainnet, testnet, signet, liquid, liquidTestnet).

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@hunicus hunicus Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sir, usage of quotes is inconsistent through the existing docs. It's more correct to include the quotes since that is the exact syntax of the response returned by the server.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot you're right, please troll @hunicus more about this

Copy link

Copilot AI commented Dec 8, 2025

@wiz I've opened a new pull request, #6154, to work on those changes. Once the pull request is ready, I'll request review from you.

@wiz wiz merged commit 76a8d82 into master Dec 9, 2025
29 checks passed
@wiz wiz deleted the hunicus/add-precise-feerexdox branch December 9, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants