feat(desktop): settings modal and sidebar color polish - #112
Merged
Conversation
Replace tab-based settings navigation with a modal overlay pattern. SettingsModalProvider context supports section-aware opening (e.g. account).
Settings no longer occupies a tab slot — opens as an overlay instead. Removes 'settings' from TabType, SINGLETON_TAB_TYPES, TAB_ICONS, and TAB_PATHS. VaultSwitcher and keyboard shortcut now use useSettingsModal.
Sidebar accent switches from tint-mixed color to neutral bg across all three themes. Active indicators use bg-tint directly. Dark mode foreground toned from #e8e6e1 to #bcbab6 for reduced eye strain.
Previous commit included a stale map from a different source state. Regenerated to match the actual committed IPC handlers.
…c button
handleSyncClick still used openTab with type: 'settings' after TabType
removal — switch to useSettingsModal('account').
h4yfans
added a commit
that referenced
this pull request
May 6, 2026
* feat(desktop): add settings modal context and dialog component
Replace tab-based settings navigation with a modal overlay pattern.
SettingsModalProvider context supports section-aware opening (e.g. account).
* refactor(desktop): replace settings tab with modal dialog
Settings no longer occupies a tab slot — opens as an overlay instead.
Removes 'settings' from TabType, SINGLETON_TAB_TYPES, TAB_ICONS, and
TAB_PATHS. VaultSwitcher and keyboard shortcut now use useSettingsModal.
* style(desktop): neutralize sidebar accent and tone dark mode foreground
Sidebar accent switches from tint-mixed color to neutral bg across all
three themes. Active indicators use bg-tint directly. Dark mode
foreground toned from #e8e6e1 to #bcbab6 for reduced eye strain.
* chore(desktop): regenerate IPC invoke map
* docs: add changelog for settings modal and sidebar polish
* fix(desktop): regenerate IPC invoke map from current source
Previous commit included a stale map from a different source state.
Regenerated to match the actual committed IPC handlers.
* fix(desktop): replace remaining settings tab reference in sidebar sync button
handleSyncClick still used openTab with type: 'settings' after TabType
removal — switch to useSettingsModal('account').
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace settings tab with a modal dialog overlay and refine sidebar/dark mode colors.
Why
Settings is a transient interaction — a modal overlay returns users to their exact context after closing, unlike a tab which competes for workspace. Sidebar accent colors were too tinted; dark mode foreground was too bright.
How
SettingsModalProvidercontext with section-awareopen(section?)for deep-linking (e.g. account)settingsfromTabTypeunion,SINGLETON_TAB_TYPES,TAB_ICONS,TAB_PATHScolor-mix(tint)to plainrgba()/#2a2a2aacross 3 themesbg-sidebar-accent-foregroundtobg-tint#e8e6e1→#bcbab6Type
feat— new featurefix— bug fixrefactor— restructure without behavior changestyle— visual/UI onlyperf— performance improvementtest— adding or updating testschore— tooling, deps, configdocs— documentation onlyci— CI/CD changesTest plan
Manual: Cmd+, opens settings modal, Esc closes. VaultSwitcher settings and sign-in buttons route through modal. Sidebar active indicators show tint color across light/warm/dark themes. Dark mode text contrast verified.
Checklist