Skip to content

fix: hide sidebar toggle in split view secondary panes - #163

Merged
h4yfans merged 2 commits into
mainfrom
fix/split-sidebar-toggle
Apr 6, 2026
Merged

fix: hide sidebar toggle in split view secondary panes#163
h4yfans merged 2 commits into
mainfrom
fix/split-sidebar-toggle

Conversation

@h4yfans

@h4yfans h4yfans commented Apr 6, 2026

Copy link
Copy Markdown
Collaborator

What

Hide the sidebar collapse icon in split view secondary panes — only the primary (leftmost) pane shows it.

Why

When splitting the view, every pane rendered its own SidebarTrigger. The toggle only makes sense next to the actual sidebar (leftmost pane). Secondary panes should show only tabs.

How

Thread a showSidebarToggle prop through the recursive SplitLayoutRenderer → TabPane → TabBarWithDrag chain. The root starts with true; at each split node, only the first child inherits the flag while the second child gets false. Handles nested splits automatically.

Type

  • fix — bug fix

Test plan

  • Manual testing (describe below)

Manual verification:

  1. Single pane → sidebar toggle visible (unchanged behavior)
  2. Split view → only left/top pane shows sidebar toggle; right/bottom pane shows only tabs
  3. Nested split (split the first pane again) → still only the leftmost pane has the toggle

Checklist

  • Self-reviewed the diff
  • No hardcoded secrets or credentials
  • Files stay under ~500 LOC
  • Follows immutable data patterns

h4yfans added 2 commits April 6, 2026 17:08
Thread showSidebarToggle prop through SplitLayoutRenderer → TabPane →
TabBarWithDrag. Only the primary (leftmost) pane shows the sidebar
collapse icon; secondary split panes show only tabs.
@h4yfans
h4yfans merged commit 88429bf into main Apr 6, 2026
2 checks passed
h4yfans added a commit that referenced this pull request May 6, 2026
fix: hide sidebar toggle in split view secondary panes
@h4yfans
h4yfans deleted the fix/split-sidebar-toggle branch May 6, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant