fix: hide sidebar toggle in split view secondary panes - #163
Merged
Conversation
Thread showSidebarToggle prop through SplitLayoutRenderer → TabPane → TabBarWithDrag. Only the primary (leftmost) pane shows the sidebar collapse icon; secondary split panes show only tabs.
h4yfans
added a commit
that referenced
this pull request
May 6, 2026
fix: hide sidebar toggle in split view secondary panes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Hide the sidebar collapse icon in split view secondary panes — only the primary (leftmost) pane shows it.
Why
When splitting the view, every pane rendered its own
SidebarTrigger. The toggle only makes sense next to the actual sidebar (leftmost pane). Secondary panes should show only tabs.How
Thread a
showSidebarToggleprop through the recursiveSplitLayoutRenderer → TabPane → TabBarWithDragchain. The root starts withtrue; at each split node, only the first child inherits the flag while the second child getsfalse. Handles nested splits automatically.Type
fix— bug fixTest plan
Manual verification:
Checklist