refactor: replace horizontal nav with vertical sidebar nav - #165
Merged
Conversation
Use shadcn SidebarMenu primitives instead of custom layout code. Move navigation from sidebar header to content area.
h4yfans
force-pushed
the
feat/vertical-nav
branch
from
April 6, 2026 14:26
4d8649d to
6614a4c
Compare
h4yfans
added a commit
that referenced
this pull request
May 6, 2026
refactor: replace horizontal nav with vertical sidebar nav
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace horizontal navigation with vertical sidebar nav using shadcn SidebarMenu primitives.
Why
Vertical sidebar nav is the standard desktop app pattern (Linear, Notion, Things). The existing horizontal nav reimplemented what the shadcn primitives already provide — active states, tooltips, collapse behavior. This eliminates ~80 lines of custom CSS and aligns with the component library.
How
sidebar-nav.tsxusingSidebarGroup/SidebarMenu/SidebarMenuItem/SidebarMenuButton/SidebarMenuBadgeprimitivesSidebarHeadertoSidebarContent(above the drill-down container)SidebarHeaderContent— now only renders traffic lights and vault switcherhorizontal-nav.tsx(114 lines replaced by 65 lines using primitives)Type
feat— new featurefix— bug fixrefactor— restructure without behavior changestyle— visual/UI onlyperf— performance improvementtest— adding or updating testschore— tooling, deps, configdocs— documentation onlyci— CI/CD changesTest plan
Verified: nav items stack vertically, badges show for Inbox/Tasks, tooltips in collapsed mode, keyboard shortcuts ⌘⌥1-4 work, drill-down (tag click) doesn't hide nav, active state highlights correctly.
Checklist