Skip to content

refactor: remove unused home tab - #167

Merged
h4yfans merged 1 commit into
mainfrom
refactor/remove-home-tab
Apr 6, 2026
Merged

refactor: remove unused home tab#167
h4yfans merged 1 commit into
mainfrom
refactor/remove-home-tab

Conversation

@h4yfans

@h4yfans h4yfans commented Apr 6, 2026

Copy link
Copy Markdown
Collaborator

What

Remove the unused Home tab from the entire tab system — it only rendered a placeholder view.

Why

The Home tab was never implemented beyond a placeholder. Removing dead code keeps the codebase lean and avoids confusion about which navigation items are functional.

How

Surgical removal across 9 source files:

  • Removed 'home' from TabType union, SINGLETON_TAB_TYPES, icon/path mappings
  • Removed SidebarHome SVG icon and sidebar nav entry
  • Removed case 'home': from tab content routing
  • Removed 'home' from BasePage type and all Record<AppPage, ...> maps
  • Renumbered sidebar keyboard shortcuts (Journal → ⌘⌥2, Tasks → ⌘⌥3)
  • Updated test fixtures and e2e comments

Kept unrelated Home references: Lucide icon (icon-picker), keyboard Home key (list navigation), English prose in seed data.

Type

  • feat — new feature
  • fix — bug fix
  • refactor — restructure without behavior change
  • style — visual/UI only
  • perf — performance improvement
  • test — adding or updating tests
  • chore — tooling, deps, config
  • docs — documentation only
  • ci — CI/CD changes

Test plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing (describe below)

TypeScript compiles clean (5/5 packages). ESLint passes (0 errors). Removed 'home' from tab-hover-preview test fixture.

Checklist

  • Self-reviewed the diff
  • No hardcoded secrets or credentials
  • Files stay under ~500 LOC
  • Follows immutable data patterns

Remove the home tab from the entire tab system. It was only rendering
a placeholder view and is not needed.

- Remove 'home' from TabType, SINGLETON_TAB_TYPES, TAB_ICONS, TAB_PATHS
- Remove Home sidebar nav entry and SidebarHome SVG icon
- Remove case 'home' from tab-content routing
- Remove 'home' from BasePage type and all Record<AppPage, ...> maps
- Remove 'home' from tab-icon TYPE_TO_ICON mapping
- Renumber sidebar shortcuts (Journal → ⌘⌥2, Tasks → ⌘⌥3)
- Update test fixtures and e2e comments
@h4yfans
h4yfans merged commit f518474 into main Apr 6, 2026
2 checks passed
h4yfans added a commit that referenced this pull request May 6, 2026
@h4yfans
h4yfans deleted the refactor/remove-home-tab branch May 6, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant