[00] add architecture boundary guardrails - #175
Merged
Conversation
h4yfans
marked this pull request as ready for review
April 8, 2026 20:52
h4yfans
added a commit
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add the first Phase 00 architecture guardrails for the desktop app by introducing a dedicated architecture boundary check, wiring it into local and CI verification, and splitting note tag-definition ownership out of the note cache query module.
Why
The architecture reset needs compiler-visible and CI-visible constraints before the broader database and IPC refactors start. This PR makes new boundary regressions fail early while preserving compatibility for the existing query surface.
How
check:contractsandcheck:architectureroot scripts and run them from desktoppretypecheckplus CIscripts/check-architecture-boundaries.jsto enforce renderer/main boundaries, protect note query ownership, and allowlist current direct IPC query importsDataDb,IndexDb, andRawIndexDbtypesDrizzleDbalias as a transitional compatibility layer so untouched call sites continue to compileType
feat— new featurefix— bug fixrefactor— restructure without behavior changestyle— visual/UI onlyperf— performance improvementtest— adding or updating testschore— tooling, deps, configdocs— documentation onlyci— CI/CD changesTest plan
Ran:
pnpm check:contractspnpm check:architecturepnpm ipc:generatepnpm ipc:checkpnpm typecheckpnpm --filter @memry/desktop exec vitest run --config config/vitest.config.ts src/main/database/client.test.ts src/main/database/queries/notes/notes.test.tsChecklist