fix(editor): restore inline date pills on the collaborative open path; legible fired reminders

[h4yfans]

What changes for the user

An inline reminder pill written into note body text survives a restart, a vault switch or a rebuild on a new device. Before this, the pill came back as a two-hundred-character base64 run — the date it stood for was unreadable, which is what the reporter hit.

A fired reminder pill now reads as a spent chip: muted text at full opacity, a settled background, a dimmed alarm icon. It keeps its date and time on the page as a record of what was scheduled, and is visually distinct from an armed pill (blue, alarm) and from a date-only pill (muted, no fill, no alarm). Red is left to mean broken.

A date token the parser refuses now degrades to a plain, readable date instead of staying an opaque blob.

Root cause

Not the escape the issue proposed. Two probes against the real converter say so: a realistic payload never reaches the base64 symbols base64url spells -/_ (the JSON is printable ASCII, and only >, ? or ~ can drive base64 onto them — no field can hold one), and when a token is forced to contain _, this serialization path emits it bare rather than escaped.

The actual break is the collaborative open path. Main parses the vault file into the shared Y.Doc with a dateMention spec whose parse claims a data-date-mention element, and markdown has none, so the token reaches the doc as plain text. useEditorSync's load effect returns early once a Y.Doc fragment is bound, so normalizeNoteBlocks — and every promoter in it — runs on the markdown path only. Nothing turned the token back into a pill. Wiki links (#1642) and inline checkboxes already close this exact gap; a date token is worse off than either, because its text carries no readable fallback at all.

promoteDateMentionsInSharedDoc closes it the same way.

Compat plan

• Token bytes are unchanged. The alphabet is closed at the same time — the encoder spells the two odd base64 symbols , and ; rather than base64url's - and _, because _ opens emphasis and sits on remark-stringify's unconditional escape list for phrasing content. No realistic payload reaches those symbols, so every token already on disk re-encodes to identical bytes. date-mention.test.ts asserts byte-for-byte equality against the old writer over 200 generated payloads. The write-back byte compare therefore rewrites nothing.
• Both alphabets parse, and a stray \ inside the run is stripped, so any token already written with an escape is healed on read.
• Graceful null is preserved. parseDateMentionToken still returns null for pre-remind-enum tokens. The degrade is a separate salvageDateMentionToken, and it restores remind: 'none' only — those tokens have armed nothing since the enum landed, so nothing is resurrected.
• Bytes with no recoverable date are left exactly as they are. An unreadable token beats a destroyed one.
• Promotion is byte-neutral. A promoted node re-serializes to the token it came from, so a second open writes no CRDT update and "opening a note must not rewrite it" (test(notes): opening a note must not rewrite it — byte stability for wiki links and custom blocks #1434) holds. A salvaged token does change the bytes, once, on a note that was already unreadable.
• Fired state stays per-device and presentational. It is still applied as a data-fired DOM attribute by use-triggered-date-pills.ts and is never written into pill props or markdown.

Verification

• pnpm lint clean. typecheck:node / typecheck:web / typecheck:test clean. pnpm typecheck fails only on a pre-existing architecture-boundary violation in apps/mobile/vitest.config.ts, which this branch does not touch.
• packages/shared/src/date-mention.test.ts — 22 passed. Covers the closed alphabet, byte identity against the old writer, a legacy base64url token with _/- runs, a backslash-escaped token, and the salvage.
• apps/desktop/src/main/sync/blocknote-converter.test.ts — 247 passed with src/main/notes/note-date-reminders.test.ts. New: a dateMention node serializes to exactly the token the renderer's promoter reads, emits only [A-Za-z0-9,;], hands an un-promotable token back byte-identical, and drops a stray escape rather than carrying it.
• date-mention-collab-promotion.test.ts — 6 passed. Real BlockNoteEditor on the real schema, real Yjs collaboration, the real hook. Covers the current token, the legacy one, the escaped one, the degrade, the untouched-bytes case, and "promotes once, writes nothing on a second open".
• Full renderer content-area suite — 792 passed, 6 skipped, 62 files.
• pnpm docs:impact --base origin/main --strict green, pnpm docs:build green, git diff --check clean.

The full conformance suite is #1848's; the link-mention half is #1844's, and link-mention.ts is untouched here.

Closes #1845

[github-actions]

React Doctor found no new issues. 🎉

_{Reviewed by React Doctor for commit 4afe775.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!