fix(scripts): exempt tooling configs from the mobile reachability walk - #1868
Closed
h4yfans wants to merge 1 commit into
Closed
fix(scripts): exempt tooling configs from the mobile reachability walk#1868h4yfans wants to merge 1 commit into
h4yfans wants to merge 1 commit into
Conversation
apps/mobile/vitest.config.ts imports node:url, which the mobile
reachability rule flags as a node builtin reachable from apps/mobile —
failing check:architecture (and with it pnpm typecheck) on main for
every branch. Tooling configs run under node by definition; the rule
exists for the app's runtime import graph. Skip *.config.{ts,js,mjs,cjs}
in walkMobileSources, the same way test files are already skipped.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
Author
|
main independently landed the same tooling-config exemption; rebasing onto main leaves zero diff, so closing as redundant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check:architecture is red on current main:
pnpm typecheckruns the check, so every branch cut from main fails it. The mobile reachability rule (spec 001-mobile-app T003) guards the app's runtime import graph; a vitest config runs under node by definition and was only picked up because the walk skips test files but not tool configs. This skips*.config.{ts,js,mjs,cjs}inwalkMobileSources, next to the existing test-file skip.Verified:
node scripts/check-architecture-boundaries.jsfails on main, passes with this change; no other walk sites touched.