Skip to content

test: align inbox IPC handler coverage with domain delegation - #192

Merged
h4yfans merged 1 commit into
memry/inbox-domain-extractionfrom
memry/inbox-phase3-ipc-thinning
Apr 9, 2026
Merged

test: align inbox IPC handler coverage with domain delegation#192
h4yfans merged 1 commit into
memry/inbox-domain-extractionfrom
memry/inbox-phase3-ipc-thinning

Conversation

@h4yfans

@h4yfans h4yfans commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

What

  • update apps/desktop/src/main/ipc/inbox-handlers.test.ts to match the desktop inbox domain delegation shape on memry/inbox-domain-extraction
  • replace stale handler expectations that still assumed the older inline IPC implementation

Why

  • this branch originally replayed a partial inbox extraction on top of a branch that already contains the broader extraction, which caused the merge conflict
  • after rebasing onto memry/inbox-domain-extraction, the only meaningful remaining delta was test coverage that matches the newer transport-only handler boundary

How

  • wrap the real createDesktopInboxDomain() in the test mock and override only the capture/retry commands under test
  • keep the actual CRUD/query/batch handler wiring so the rest of the handler test file still exercises the rebased branch shape
  • update stale assertions for image capture delegation and archive behavior to match the current implementation

Type

  • feat
  • fix
  • refactor
  • docs
  • test
  • chore

Test plan

  • Unit tests added/updated
  • Manual testing
  • ./node_modules/.bin/vitest run --config config/vitest.config.ts --project main src/main/ipc/inbox-handlers.test.ts
  • ./node_modules/.bin/eslint --no-warn-ignored src/main/ipc/inbox-handlers.test.ts

Screenshots

  • N/A

Checklist

  • Self-reviewed code
  • Updated tests to match current behavior
  • Resolved the branch conflict against memry/inbox-domain-extraction

@h4yfans
h4yfans changed the base branch from memry/inbox-domain-extraction to main April 9, 2026 22:20
@h4yfans
h4yfans force-pushed the memry/inbox-phase3-ipc-thinning branch from 4fbe71c to 8e4221d Compare April 9, 2026 22:31
@h4yfans h4yfans changed the title refactor: extract inbox capture commands from IPC test: align inbox IPC handler coverage with domain delegation Apr 9, 2026
@h4yfans
h4yfans changed the base branch from main to memry/inbox-domain-extraction April 9, 2026 22:31
@h4yfans
h4yfans merged commit f76510f into memry/inbox-domain-extraction Apr 9, 2026
1 check passed
@h4yfans
h4yfans deleted the memry/inbox-phase3-ipc-thinning branch April 9, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant