refactor: move note writes behind projection events - #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Move normal note and journal write paths fully onto domain-event/projector flows instead of draining projections inline.
Why
Phase 4 was marked complete, but local note and journal mutations still awaited projector execution and rename/repair compatibility paths could still mutate index state directly.
How
flushProjectionEvents()waits from local note CRUD and journal IPC mutation handlersnotes.tsthroughdeleteNoteFromCacheandsyncNoteToCacheinstead of direct cache/canonical writesrename-trackerto detect and emit rename events only, and replayed markdown renames throughsyncNoteToCachein the watchervoid flushProjectionEvents()note_cachevisibilityType
feat— new featurefix— bug fixrefactor— restructure without behavior changestyle— visual/UI onlyperf— performance improvementtest— adding or updating testschore— tooling, deps, configdocs— documentation onlyci— CI/CD changesTest plan
Unit tests added/updated
Integration tests added/updated
Manual testing (describe below)
pnpm exec vitest run --config config/vitest.config.ts --project main src/main/ipc/journal-handlers.test.ts src/main/vault/notes.test.ts src/main/vault/rename-tracker.test.ts src/main/vault/watcher.test.tspnpm typecheck:desktopScreenshots
N/A
Checklist