Add offline body-CRDT sync E2E coverage - #196
Merged
Merged
Conversation
…Google redirect URI and OTP HMAC key
…-device scenarios
…fline transitions
…ontrol with sync helpers
… monitoring for sync control
…s and document conversion
…tegrate it into FullSyncRunner
…tion with applied sequence management
h4yfans
marked this pull request as ready for review
April 10, 2026 17:41
h4yfans
added a commit
that referenced
this pull request
Apr 10, 2026
5 tasks
h4yfans
added a commit
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add deterministic dual-device desktop E2E coverage for body-only note CRDT sync, and fix the sync/runtime gaps that the new coverage exposed.
Why
We needed reliable regression coverage for the core offline sync scenarios across two devices:
2 notes / 4 editscross-edit flowWithout this, the desktop app could regress on convergence behavior without a stable end-to-end signal.
How
docs/superpowers/plans/2026-04-10-body-crdt-sync-e2e-checklist.md.Type
fix— bug fixfeat— new featurerefactor— restructure without behavior changestyle— visual/UI onlyperf— performance improvementtest— adding or updating testschore— tooling, deps, configdocs— documentation onlyci— CI/CD changesTest plan
Commands run:
pnpm testpnpm --dir apps/sync-server exec vitest run schema/d1.test.tspnpm --dir apps/desktop exec vitest run --config config/vitest.config.ts src/main/sync/engine/crdt-sync-coordinator.test.tspnpm --dir apps/desktop exec vitest run --config config/vitest.config.ts src/main/sync/engine.test.ts -t "#given WS reconnect #when handleWsConnected fires"pnpm --dir apps/desktop exec playwright test --config config/playwright.config.ts tests/e2e/body-crdt-create-propagation.e2e.tspnpm --dir apps/desktop exec playwright test --config config/playwright.config.ts tests/e2e/body-crdt-single-writer-edit.e2e.tspnpm --dir apps/desktop exec playwright test --config config/playwright.config.ts tests/e2e/body-crdt-different-note-edit.e2e.tspnpm --dir apps/desktop exec playwright test --config config/playwright.config.ts tests/e2e/body-crdt-same-note-merge.e2e.tspnpm --dir apps/desktop exec playwright test --config config/playwright.config.ts tests/e2e/body-crdt-coverage-variants.e2e.tspnpm --dir apps/desktop test:e2e -- dual-device-isolation.e2e.ts shared-sync-bootstrap.e2e.ts network-control.e2e.ts note-sync-helpers.e2e.ts manual-sync-smoke.e2e.ts body-crdt-create-propagation.e2e.tsChecklist