feat: move search to sidebar top and fix settings scroll - #199
Merged
Conversation
The previous regeneration commit (218c818) captured a working-tree state that didn't reflect the committed contracts. Running the generator fresh against this branch's contracts produces the inverse diff. This commit restores the bindings to the correct generator output so ipc:check passes.
h4yfans
added a commit
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two related sidebar/settings improvements bundled together:
Why
How
Sidebar reorder (
app-sidebar.tsx):Settings scroll fix — root cause was that Radix
DialogContentrenders asdisplay: gridwith implicitautorows. When the sole grid item (SettingsPage) ish-full, the row track isauto, which can't give the child a definite height — nestedoverflow-hidden+ScrollAreanever trigger a scroll boundary, so long sections silently overflow the dialog.Scoped fix (avoids touching the base
Dialogprimitive which other dialogs rely on):settings-modal.tsx: addedflex flex-colto the settingsDialogContentoverride, breaking the grid at this usage sitesettings.tsx:<div>:h-full flex→flex-1 min-h-0 flexso it fills the flex-column parent with a definite heightoverflow-y-auto min-h-0so the nav becomes independently scrollable when the window is very shortmin-h-0sooverflow-hiddenactually clips and the nestedScrollAreacomputes bounded viewport heightIPC bindings regen: folded in as a separate
chore:commit — the bindings were already stale onmain(blockingpnpm typecheck's pretypecheck hook), so this unblockspnpm ipc:checkas a side benefit.Type
feat— new feature (sidebar reorder)fix— bug fix (settings scroll)chore— tooling, deps, config (IPC regen)Test plan
pnpm test)Checklist