Skip to content

style: align sidebar nav rows with folder/file row styling - #200

Merged
h4yfans merged 2 commits into
mainfrom
feat/sidebar-nav-align
Apr 11, 2026
Merged

style: align sidebar nav rows with folder/file row styling#200
h4yfans merged 2 commits into
mainfrom
feat/sidebar-nav-align

Conversation

@h4yfans

@h4yfans h4yfans commented Apr 11, 2026

Copy link
Copy Markdown
Collaborator

What

Align sidebar nav rows (Inbox, Journal, Tasks) with folder/file row styling for visual consistency.

Why

The top-level sidebar nav rows were visually inconsistent with the folder/note rows in the Collections section below. They used a taller, chunkier row primitive while folder/file rows used a tighter tree-node style. This made the nav feel like "bolted-on chrome" instead of a continuous list.

How

Added a single className override to <SidebarMenuButton> in sidebar-nav.tsx:53 that copies the exact tokens from TreeNodeTrigger:

  • Height: h-8h-7 (32px → 28px)
  • Radius: rounded-mdrounded-[5px] (6px → 5px)
  • Padding: p-2p-0 pl-1 pr-2.5 (asymmetric: 4px left / 10px right)
  • Gap: gap-2gap-1.5 (8px → 6px)
  • Font: text-smtext-[13px] leading-4 font-medium
  • Text color: text-sidebar-foreground

The twMerge conflict resolver picks the later class, so the override cleanly wins. The CVA's [&>svg]:size-4 and hover/active color tokens remain unchanged.

Type

  • style — visual/UI only

Test plan

  • Manual testing (visual verification: hover, selected state, collapsed rail, dark mode, badge clipping)
  • All existing unit + integration tests pass (262 test files, 5,557 tests)
  • Lint clean (no new errors)
  • Typecheck clean (all packages, contracts, IPC verified)

Checklist

  • Self-reviewed the diff
  • No hardcoded secrets or credentials
  • Single file under 500 LOC (sidebar-nav.tsx is 67 lines)
  • Follows immutable data patterns (no state mutations)

@h4yfans
h4yfans merged commit c076ba5 into main Apr 11, 2026
1 check passed
h4yfans added a commit that referenced this pull request May 6, 2026
style: align sidebar nav rows with folder/file row styling
@h4yfans
h4yfans deleted the feat/sidebar-nav-align branch May 6, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant