fix(desktop): normalize Windows inbox filing paths - #201
Merged
Conversation
…der-filing # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix Windows inbox folder filing by normalizing vault-relative paths and the inline folder-create flow.
Why
A Windows user reported in #136 that creating a folder while filing a note/link could leave the app unresponsive, and after restart the folder existed but the item still remained in Inbox. The filing flow was mixing Windows
\\-delimited relative paths with/-delimited folder ids.How
normalizeRelativePathand use it anywhere the desktop app emits vault-relative note, folder, watcher, inbox, or attachment pathsType
fix— bug fixfeat— new featurerefactor— restructure without behavior changestyle— visual/UI onlyperf— performance improvementtest— adding or updating testschore— tooling, deps, configdocs— documentation onlyci— CI/CD changesTest plan
pnpm lintpnpm typecheckpnpm testpnpm ipc:checkScreenshots
Checklist