[0.3] fix(types): unblock websocket.test.ts type errors - #206
Merged
Conversation
h4yfans
added a commit
that referenced
this pull request
May 6, 2026
[0.3] fix(types): unblock websocket.test.ts type errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a TypeScript type assertion to the
require('events')call insidevi.hoisted()inapps/desktop/src/main/sync/websocket.test.tsso the returned module namespace is typed correctly without enablingesModuleInteropproject-wide.The CJS
require('events')returnedany, which flowed through the destructuredEventEmitterand intoclass MockWS extends EE, cascading into ~45 downstream type errors in that file when checked againsttests/tsconfig.json.Fix applied
This was option (b) from the task spec — cast the
requireresult to the proper ES module namespace type. No tsconfig changes needed; avoids the broader blast radius of turning onesModuleInterop/allowSyntheticDefaultImports.Before / after
apps/desktop/src/main/sync/websocket.test.tswhen typechecked viatests/tsconfig.json.websocket.test.ts. Confirmed viapnpm exec tsc --noEmit -p tests/tsconfig.json— remaining errors are in unrelated test files (calendar, inbox, ipc handlers) and outside this unit's scope.pnpm --filter @memry/desktop typecheck:node— passes cleanly (test files already excluded by production tsconfig; no regressions).pnpm --filter @memry/desktop exec vitest run src/main/sync/websocket.test.ts— 28/28 tests pass.Test plan
websocket.test.tstypechecks clean viatests/tsconfig.jsonwebsocket.test.tsruntime — all 28 tests passtypecheck:nodestill green (test files excluded there)