chore(crypto): add Phase 1 golden-vector fixture scaffolding - #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Phase 1 §1.1 of
.claude/plans/tech-debt-remediation.md.Summary
Seeds
apps/desktop/src/main/crypto/__fixtures__/with RFC-derived test vectors + a typed loader for Phase 1 crypto tests.Files
load-vectors.ts—XChaCha20Vector/Ed25519Vector/Argon2idVectorinterfaces +assert*Vectorshape-check helpers + synchexToBytes(nosodium.readydep).xchacha20-rfc8439.ts—draft-irtf-cfrg-xchacha-03 §A.3.1canonical AEAD vector (114-byte plaintext, ciphertext + Poly1305 tag separate).ed25519-rfc8032.ts— RFC 8032 §7.1 TEST 1 (empty message) + TEST 2 (single byte 0x72). 32-byte seeds; libsodium reconstructs 64-byte SK viacrypto_sign_seed_keypair.argon2id-rfc9106.ts— RFC 9106 §5.3 reference (p=4, T=32, m=32 KiB, t=3, v=0x13). README documents Memry-vs-RFC parallelism deviation.README.md— file table, source URLs, vector-shape contract, regen recipe.Test plan
pnpm typecheck:nodepassespnpm lintpasses🤖 Generated with Claude Code