test(crypto): add dedicated signatures coverage (RFC 8032 + tombstone regression) - #219
Merged
Conversation
… regression) (Phase 1.3)
h4yfans
added a commit
that referenced
this pull request
May 6, 2026
… regression) (Phase 1.3) (#219)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Phase 1 §1.3 of
.claude/plans/tech-debt-remediation.md.Summary
Adds a dedicated test file for
signatures.ts(previously only tangential coverage infoundation.test.ts). Includes RFC 8032 golden vector + load-bearing tombstone regression that prevents server-forged deletions.New tests (8)
signPayloaddeterminism for fixed seed+payloadverifySignaturereturns falsedeletedAt→ stripping the field breaks verification (prevents server-forged deletion per MEMORY.md)deletedAtto earlier timestamp → verify failsCBOR_FIELD_ORDER.TOMBSTONE)Test plan
pnpm --filter desktop test --project main src/main/crypto/signatures.test.ts— 0 failuressignatures.ts≥ 95% (file is 22L, 2 fns — should land at 100%)pnpm typecheck:node && pnpm typecheck:webcleanpnpm lintclean🤖 Generated with Claude Code