test(crypto): keychain coverage with mocked keytar + optional macOS E2E - #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Phase 1 §1.5 of
.claude/plans/tech-debt-remediation.md.Summary
Dedicated coverage for
keychain.ts(55L) via mockedkeytarunit tests, plus an env-gated real-keychain E2E for manual macOS smoke.New files
keychain.test.ts— 17 tests coveringstoreKey,retrieveKey,deleteKey,MEMRY_DEVICEaccount suffix branch, error wrapping (Error + non-Error throwables), null/empty-string falsy guard in retrieve,deletePassword=falseidempotency, end-to-end store↔retrieve roundtrip across allKEYCHAIN_ENTRIES.keychain.e2e.test.ts— env-gated (KEYCHAIN_E2E=1) real-keychain roundtrip; skipped by default in CI.Coverage targets (hand-review)
All 3 functions exercised; all 3 try/catch branches exercised; both
err instanceof Errorternary branches exercised; bothresolveAccountbranches exercised;if (!encoded) return nullexercised twice (null + empty string). Should yield 100% line + branch + function coverage.Test plan
pnpm --filter desktop test --project main src/main/crypto/keychain.test.ts— 0 failures (E2E skipped by default)keychain.ts≥ 95%pnpm typecheck:node && pnpm typecheck:webcleanpnpm lintcleanKEYCHAIN_E2E=1 pnpm ... keychain.e2e.test.tson macOS🤖 Generated with Claude Code