test(rpc): add schema + domain coverage - #226
Merged
Merged
Conversation
Phase 4 U2 — adds Vitest coverage for @memry/rpc package (previously 0 tests). Covers defineMethod/defineEvent/defineDomain factories in schema.ts and validates Zod schemas across all 5 domain specs (tasks, notes, inbox, settings, calendar) with valid + invalid fixtures. Runs inside desktop shared vitest project via glob added in #224. Ref: .claude/plans/tech-debt-remediation.md Phase 4.2
h4yfans
added a commit
that referenced
this pull request
May 6, 2026
Phase 4 U2 — adds Vitest coverage for @memry/rpc package (previously 0 tests). Covers defineMethod/defineEvent/defineDomain factories in schema.ts and validates Zod schemas across all 5 domain specs (tasks, notes, inbox, settings, calendar) with valid + invalid fixtures. Runs inside desktop shared vitest project via glob added in #224. Ref: .claude/plans/tech-debt-remediation.md Phase 4.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 4 U2 — adds Vitest coverage for
@memry/rpcpackage (previously 0 tests).schema.test.ts— defineMethod/defineEvent/defineDomain factory teststasks.test.ts/notes.test.ts/inbox.test.ts/settings.test.ts/calendar.test.ts— per-domain Zod schema validation (valid + invalid)index.test.ts— rpcDomains array smoke testRelies on domain-tasks + rpc globs from #224.
Test plan
pnpm --dir apps/desktop test:coveragegreenRef: .claude/plans/tech-debt-remediation.md Phase 4.2