docs(testing): audit vitest 4 patterns + add testing-vitest.md - #249
Merged
Conversation
Documents the current Vitest 4 baseline for the memry test suite: - Current versions across workspaces - 3-project layout (shared/main/renderer) from vitest.config.ts - Coverage ratchet pinned at 37/28/34/38 (baseline 2026-04-15) - Audit findings: zero v3-era deprecated patterns found - Idioms in use (default-export mocks, typed vi.fn, jsdom renderer setup) - File layout conventions (tests/utils/fixtures/ placement, Phase 3.3) - Known gotchas (Zod v4 record, better-sqlite3 ABI, pre-existing errors) No code changes needed — audit came back clean. Plan: .claude/plans/tech-debt-remediation.md § 6.4
h4yfans
added a commit
that referenced
this pull request
May 6, 2026
Documents the current Vitest 4 baseline for the memry test suite: - Current versions across workspaces - 3-project layout (shared/main/renderer) from vitest.config.ts - Coverage ratchet pinned at 37/28/34/38 (baseline 2026-04-15) - Audit findings: zero v3-era deprecated patterns found - Idioms in use (default-export mocks, typed vi.fn, jsdom renderer setup) - File layout conventions (tests/utils/fixtures/ placement, Phase 3.3) - Known gotchas (Zod v4 record, better-sqlite3 ABI, pre-existing errors) No code changes needed — audit came back clean. Plan: .claude/plans/tech-debt-remediation.md § 6.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of Phase 6 Tech Debt Remediation — see
.claude/plans/tech-debt-remediation.md § 6.4.Summary
New
docs/testing-vitest.mddocumenting the current Vitest 4 baseline.Audit findings: zero v3-era deprecated patterns across the test suite.
pnpm testoutput emits no deprecation warnings. No code changes needed — the migration to Vitest 4 is clean.What the doc covers
vitest.config.tsvi.mock(path, () => ({ default: { ... } }))for default-export mocksvi.fn<typeof fetch>()for typed mocksvi.mocked(foo)for reasserting types on already-mocked modulestests/utils/fixtures/per Phase 3.3)better-sqlite3 ERR_DLOPEN_FAILEDsymptomTest plan
pnpm test 2>&1 | grep -iE 'deprecated|will be removed'returns 0 hits