chore(deps): remove unused libsodium-wrappers dep, keep -sumo variant - #251
Merged
Conversation
libsodium-wrappers (^0.8.0) was declared in apps/desktop/package.json but imported zero times across the entire workspace. All 43 crypto + sync call sites use libsodium-wrappers-sumo (^0.8.2), a strict superset. Shipping two copies of the same crypto primitive library increases bundle size and creates ambiguity in security review. This PR drops the unused plain-wrapper dep. Verification before removal: - grep 'from .libsodium-wrappers.' apps/desktop/src/ → 0 - grep 'from .libsodium-wrappers.' memry/ (whole repo) → 0 - No @types/libsodium-wrappers (plain) to remove; only @types/libsodium-wrappers-sumo is declared. Delta: - apps/desktop/package.json: 1 line removed - pnpm-lock.yaml: 15 lines removed (package entry + refs) No code changes. No behavior change. Plan: .claude/plans/tech-debt-remediation.md § 6.2
h4yfans
added a commit
that referenced
this pull request
May 6, 2026
…#251) libsodium-wrappers (^0.8.0) was declared in apps/desktop/package.json but imported zero times across the entire workspace. All 43 crypto + sync call sites use libsodium-wrappers-sumo (^0.8.2), a strict superset. Shipping two copies of the same crypto primitive library increases bundle size and creates ambiguity in security review. This PR drops the unused plain-wrapper dep. Verification before removal: - grep 'from .libsodium-wrappers.' apps/desktop/src/ → 0 - grep 'from .libsodium-wrappers.' memry/ (whole repo) → 0 - No @types/libsodium-wrappers (plain) to remove; only @types/libsodium-wrappers-sumo is declared. Delta: - apps/desktop/package.json: 1 line removed - pnpm-lock.yaml: 15 lines removed (package entry + refs) No code changes. No behavior change. Plan: .claude/plans/tech-debt-remediation.md § 6.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of Phase 6 Tech Debt Remediation — see
.claude/plans/tech-debt-remediation.md § 6.2.Summary
Removes the unused
libsodium-wrappers: ^0.8.0dep fromapps/desktop/package.json. All 43 crypto + sync source sites uselibsodium-wrappers-sumo: ^0.8.2(a strict superset); the plain wrapper was dead code.Verification before removal
grep "from 'libsodium-wrappers'" apps/desktop/src/→ 0 matchesgrep "from 'libsodium-wrappers'" .(whole repo) → 0 matches@types/libsodium-wrappers(plain) declared — only@types/libsodium-wrappers-sumo, which stays.Why
Two copies of the same crypto library in a desktop app:
-sumois a strict superset)Delta
apps/desktop/package.json: 1 line removedpnpm-lock.yaml: 15 lines removed (the fulllibsodium-wrappers@0.8.0package entry)Test plan
pnpm install --frozen-lockfilegreenpnpm typecheckgreen (crypto path untouched — only -sumo used)pnpm testgreen (crypto tests in particular)