Skip to content

fix(e2e): make T541 row-position drop test independent of task sort order #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
h4yfans merged 1 commit into from
Apr 17, 2026
Merged

fix(e2e): make T541 row-position drop test independent of task sort order #254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions apps/desktop/tests/e2e/tasks.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,11 @@ test.describe('Tasks Management', () => {
await expect(firstHighRow).toBeVisible()
await expect(secondHighRow).toBeVisible()

await moveDraggedTaskToTarget(page, sourceRow, firstHighRow, { yRatio: 0.2 })
// Hover over the SECOND row's top edge so the row-position assertion is
// distinguishable from a section-start drop. Hovering over the first row's
// top edge would put insertIndex at 0 — visually identical to a header drop
// and would only verify section membership, not row-position semantics.
await moveDraggedTaskToTarget(page, sourceRow, secondHighRow, { yRatio: 0.2 })

await expect(firstHighRow).toHaveAttribute('data-section-drag-state', 'target-highlighted')
await expect(secondHighRow).toHaveAttribute('data-section-drag-state', 'target-highlighted')
Expand All @@ -398,8 +402,8 @@ test.describe('Tasks Management', () => {
expect(firstHighIndex).toBeGreaterThanOrEqual(0)
expect(sourceIndex).toBeGreaterThanOrEqual(0)
expect(secondHighIndex).toBeGreaterThanOrEqual(0)
expect(secondHighIndex).toBeLessThan(sourceIndex)
expect(sourceIndex).toBeLessThan(firstHighIndex)
expect(firstHighIndex).toBeLessThan(sourceIndex)
expect(sourceIndex).toBeLessThan(secondHighIndex)
})

test('T541: should keep intermediate sections visually stable during cross-section drags', async ({
Expand Down
Loading