fix(e2e): give note-list sync poll 30s headroom for CI runners - #255
Merged
Conversation
Manual-sync-smoke and other CRDT/sync tests were timing out in CI shard 2/3 at note-sync-helpers.ts:101 with the default 10 s expect.poll budget, even though the underlying sync IS landing the note on device B. Diagnostic findings: - Test passes 5/5 locally in 10.8-12.3 s end-to-end. - The post-sync poll typically resolves in ~100 ms (the note is in B's index right after syncBothAndWait returns with pendingCount=0). - The note-handler insert branch already calls flushProjectionEvents() and emits NotesChannels.events.CREATED — no missing wiring. - CI runners under shard load have been observed to spend >10 s between the sync settling and the renderer's window.api.notes.list reflecting the new row. This appears to be CI resource pressure rather than a product bug. Fix is minimal: bump the helper's poll budget to 30 s with a comment explaining why. No product code changed; no other helpers altered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Manual-sync-smoke (and the body-CRDT same-note merge tests, which use the same helper) timed out in CI shard 2/3 at `note-sync-helpers.ts:101` after the default 10 s `expect.poll` budget. The poll waits for device B's `notes.list({})` to surface the note that device A pushed.
Diagnostic findings
Change
No product code changes. No other helpers altered.
Test plan