test(calendar): e2e coverage for M2 promote-external flow - #280
Merged
Conversation
Add Playwright coverage for the M2 user-visible path that clicking an externally-owned Google event surfaces the promote confirmation dialog, and confirming it opens the edit popover on the newly-promoted native calendar_events row. Five tests cover: dialog copy, cancel, confirm, rename-and-save after promote, and the promoteConfirmDismissed shortcut. Also replace the pre-M2 test.skip placeholder in calendar-comprehensive with a pointer to the new file now that the interaction contract is finalized. Internal correctness (binding ownership, mirror archival, idempotency, 412 retries, 410 recovery, field-clock merges) remains covered by the existing unit suites; this change only closes the E2E gap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds end-to-end Playwright coverage for the only M1/M2/M3 user-visible flow that lacked it: clicking an externally-owned Google calendar event and promoting it into a native Memry event.
M1 (correctness fixes) and M3 (etag + field-clock conflict resolution) are entirely internal to the sync layer — their unit suites in `sync-service.test.ts`, `field-merge-calendar.test.ts`, `onboarding.test.ts`, and `promote-external-event.test.ts` already exercise every branch with a mocked `GoogleCalendarClient`. M2's promote flow is the one path that crosses main ↔ renderer ↔ DB and needed regression protection at the Playwright layer.
What changed
Reuses the existing `seedCalendarProjection` test hook — no new test infrastructure.
Test plan
Notes for reviewer