Skip to content

feat(inbox): remove the triage feature entirely - #628

Merged
h4yfans merged 2 commits into
mainfrom
remove-inbox-triage
Jun 29, 2026
Merged

feat(inbox): remove the triage feature entirely#628
h4yfans merged 2 commits into
mainfrom
remove-inbox-triage

Conversation

@h4yfans

@h4yfans h4yfans commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

What

Removes the dedicated inbox Triage mode (the card/swipe view) and all its supporting code. Inbox items are still processed inline from the list and detail views — file / snooze / archive / convert to task or note — only the separate triage surface is gone.

This also covers "Triage 2": that view only ever lived on the unmerged PR #627, which this supersedes (closing it).

Removed

  • pages/inbox/triage-view.tsx (+test)
  • components/inbox/: triage-action-bar, triage-item-card, triage-progress, triage-complete, triage-snooze-picker, streak-badge
  • hooks/use-triage-queue.ts
  • triage-mode wiring in pages/inbox.tsx (Triage button, Cmd+P toggle, memry:enter-triage event, Escape handler)
  • triage.* i18n block + dead view.triageButton/view.processInboxTitle keys
  • unused TriageAction/TriageState contract types + domain-inbox TriageAction

Adjusted

  • Home inbox-widget archive button: aria-label repointed triage.action.archivequickActions.archiveItem
  • Home inbox footer button relabeled "Triage inbox" → "Open inbox" (it only navigates to the inbox; testid inbox-triageinbox-open)
  • pruned triage references from 7 affected test files

Deliberately kept (flagging)

  • Home header "to triage" metric (toTriage in header-helpers.ts) — this is a passive count of unprocessed inbox items, not the triage feature; renaming ripples through a typed metric enum + i18n. Say the word and I'll rename it (e.g. "to process").
  • Agent system-prompt line prompt-assembler.ts "Inbox triage → …" — describes the agent's inbox-processing capability (still backed by live vault_archive_inbox_item etc.), not the removed UI.

Verify

  • typecheck:web + typecheck:node clean
  • i18n:check passed
  • affected renderer tests: 75 files pass, 0 fail
  • eslint clean on changed source; no physical Tailwind classes

Draft — pending GUI QA.

Removes the dedicated inbox triage mode (the card/swipe 'Triage' view) and all
its supporting code. Inbox items are still processed inline from the list and
detail views (file / snooze / archive / convert to task or note) — only the
separate triage surface is gone.

- delete triage-view + triage-action-bar / item-card / progress / complete /
  snooze-picker + streak-badge + use-triage-queue hook
- strip triage-mode wiring from the inbox page (Triage button, Cmd+P toggle,
  memry:enter-triage event, Escape handler)
- remove the triage.* i18n block and dead view.triageButton/processInboxTitle
  keys; repoint the Home inbox-widget archive aria-label to quickActions.archiveItem;
  relabel the Home inbox footer 'Triage inbox' -> 'Open inbox'
- drop the now-unused TriageAction/TriageState contract types and the
  domain-inbox TriageAction type
- prune triage references from affected tests
@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown

React Doctor

React Doctor found 2 issues in 1 file.

Score Issues Errors Warnings Affected Files Scope
93 / 100 (Great) 2 0 2 1 19 files changed on remove-inbox-triage vs. main

Top Findings

Rule Severity Category Count
react-doctor/control-has-associated-label warning Accessibility 1
react-doctor/jsx-no-jsx-as-prop warning Performance 1

View workflow run

Generated by React Doctor. Questions? Contact founders@million.dev.

@github-actions github-actions Bot added enhancement New feature or request test labels Jun 29, 2026
- drop Home header "to triage" metric (toTriage) + its i18n key
- reword agent prompt "Inbox triage" -> "Inbox processing" (workflow kept)
- delete dead componentsInboxTriageItemCard i18n keys (component already removed)
@h4yfans
h4yfans marked this pull request as ready for review June 29, 2026 18:18
@h4yfans
h4yfans merged commit 9036368 into main Jun 29, 2026
12 of 14 checks passed
@h4yfans
h4yfans deleted the remove-inbox-triage branch June 29, 2026 18:18
h4yfans added a commit that referenced this pull request Jun 29, 2026
Resolve modify/delete conflicts from #628 (triage feature removed entirely):
accept upstream deletion of triage-action-bar.tsx and triage-view.tsx, and
drop the now-orphaned Task 8 triage-action-bar.test.tsx. Other flag-gating
changes are in non-triage files and merge cleanly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant