feat(desktop): configurable date format + calendar date-property picker#671
Merged
Conversation
- Add device-local dateFormat general setting (MM/DD/YYYY, DD/MM/YYYY, YYYY-MM-DD, DD.MM.YYYY), mirroring clockFormat - Central lib/format-date.ts (formatDate/parseDateInput) + reactive useDateFormat hook + global cache sync in useThemeSync - Apply the setting to every full-date display: property rows, folder table, task due dates, doc-info panels, tab/wiki previews, version history - Replace free-text date-property entry with a self-managed calendar popover picker (reuses DatePickerCalendar)
github-actions
Bot
added
documentation
|
React Doctor found no issues. 🎉 Reviewed by React Doctor for commit |
h4yfans
added a commit
that referenced
this pull request
Jul 3, 2026
Desktop tests (Unit coverage step) had accumulated pre-existing failures masked behind the CLI-test red (which skipped the desktop step): - crdt-provider: add repairEmptyBlockIds to blocknote-converter mock (#679) - date rendering (date-grouping, format-task-due, tab-preview-card, missing-small-components, component-major-surfaces): expect DD.MM.YYYY default from configurable date format (#671) - general-section.i18n: tabCloseButton is selects[3] after the added dateFormat select (#671) - settings-sections: editor/journal switch indices shift +1 after the calendar notes-on-calendar switch (#667) - missing-small-components: add getI18n to react-i18next mock (fixes an unhandled rejection that failed the whole run) E2E auth-state-machine: recovery-phrase words are semantic <li> after the React Doctor a11y pass (#639) dropped explicit role=listitem; query by 'li'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a configurable date format and replaces free-text date-property entry with a calendar pop-up picker.
MM/DD/YYYY(US),DD/MM/YYYY,YYYY-MM-DD,DD.MM.YYYY(default). Device-local (not synced); mirrors the Clock Format setting end-to-end.DatePickerCalendar); you can also type the date, parsed in the chosen format.Implementation
dateFormatenum added toGeneralSettingsSchema(+ app-core defaults, preload DTO, i18n, settings UI). No new IPC channel — the generic General get/set handlers carry it.lib/format-date.ts(formatDate/parseDateInput) + reactiveuseDateFormathook; the module cache is kept in sync globally viauseThemeSync.Testing
pnpm --filter @memry/desktop typecheck✅pnpm --filter @memry/contracts test— 75 pass, incl. newdateFormatenum case ✅format-date,editors,PropertyRow,property-cell✅pnpm lint,pnpm ipc:check,i18n:check,pnpm docs:build✅