feat(desktop): scale editor text and tags with Appearance font size#680
Merged
Conversation
BlockNote pinned editor body to a fixed 16px, so the Appearance -> Font Size (S/M/L) setting never reached note text. Tie .bn-default-styles to 1rem (the root font-size useThemeSync already sets) so editor body, inline #tags (0.9em), and tags-row chips all scale with the setting. Identical to today at Medium.
|
React Doctor found no issues. 🎉 Reviewed by React Doctor for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Appearance → Font Size (S/M/L) now scales BlockNote editor body text, inline #tags (0.9em), and tag-row chips. BlockNote pinned
.bn-default-stylesto a fixed 16px, so the setting never reached editor text; re-tying it to1rem(the root font-sizeuseThemeSyncalready sets) makes it scale. Tag-row chips move from fixedtext-[12px]to rem-basedtext-xs. Identical to today at Medium.Why
Customer report: tag text too small to read, and the font-size setting had no effect inside the note editor.