feat(desktop): in-app update prompt replacing native dialog#681
Merged
Conversation
|
React Doctor found no issues. 🎉 Reviewed by React Doctor for commit |
Replace the native showMessageBox update prompts with an in-app modal (app icon, version diff, scrollable release notes, auto-update checkbox, Skip / Remind Me Later / Download; Restart Now / Later once downloaded). Adds skip-version + auto-download persistence and two IPC channels.
7b43034 to
aa92d4f
Compare
h4yfans
added a commit
that referenced
this pull request
Jul 3, 2026
- Restore dateFormat to GeneralSettingsDTO (dropped in #681 rebase), fixing renderer typecheck in use-date-format/use-theme-sync/general-section - Add optional onBlur to DateEditor so folder-view EditablePropertyCell exits edit mode on picker close (matches sibling editors) - Add missing dateFormat to app-core general-settings test assertions - Add missing count.journal/event/reminder ICU keys used by date-picker-calendar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace the native
showMessageBoxupdate prompts with an in-app modal: app icon, version diff, scrollable release notes, an "automatically download & install" checkbox, and Skip This Version / Remind Me Later / Download — then Restart Now / Later once downloaded.Why
The native OS prompt can't show release notes richly or offer skip/remind/auto-update. The modal matches the app's design system and the requested layout, and adds skip-version + auto-download persistence (two new updater IPC channels).