Apply a template to an existing note#721
Merged
Merged
Conversation
… apply + guard double-submit
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply a template to an existing note
Templates previously only applied at note creation, folder-default, and journal-default. This adds the ability to apply a template to an existing individual note from two entry points.
Behavior
{{title}}resolves to the note's current title.Implementation
notes:apply-template({ noteId, templateId, mode: 'full' | 'body' }) → contract + rpc + handler.applyTemplateToNote: purebuildTemplateApplyUpdate(tag union, existing-wins property merge,{{title}}), reusesupdateNoteCommand(file + index + sync), then feeds the open editor's Y.Doc.replaceNoteBodyInCrdtfrom the vault watcher into a sharedcrdt-feedmodule so external-edit and template-apply share one fragment-replace path.TemplateSelectorgains an apply mode; new confirmation dialog; a self-contained orchestrator dialog mounted at both entry points (inert while closed).Notes
apps/docs/src/user-guide/templates.md.Verification
ipc:check,i18n:check, docs-impact + docs:build all green.Test plan