Release blocker: Linux AppImage fails under electron-builder 26.15 (executableName validation)#737
Merged
Merged
Conversation
…n-builder 26.15
electron-builder >=26.13 validates executableName and rejects the
package.json-derived fallback @memrydesktop ('contains characters that
cannot be safely used in file paths'), failing the Linux release job.
Windows already overrides (Memrynote); give Linux an explicit safe name.
userData paths are untouched — they derive from app.name, not the
binary name; the .desktop Exec entry is regenerated by the package.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
Local cross-build proof (macOS host, electron-builder 26.15.6, same config + the Same validation path that failed the release run ( |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Release run 29096552456 (v2026.710.3): Build Linux x64 fails with
electron-builder ≥26.13 (we bumped to 26.15.6 in #736) validates
executableNameand rejects the fallback derived from the package.json name@memry/desktop. The old version accepted it silently. Windows already setswin.executableName: Memrynote; Linux had no override. Windows x64 and macOS jobs in the same run are green — this is the only blocker.What
One line:
linux.executableName: memrynote.app.name(package.jsonname), never from the binary name. The known landmine (renaming app identity relocates user data) does not apply here.@memrydesktoptomemrynote; the.desktopExec entry is regenerated by electron-builder, so launchers keep working. Only hand-made shortcuts to the old binary path inside/optwould need re-pointing — unavoidable, since the old name is now rejected outright.Proof
After merge: re-dispatch
publish-release.yml— it checks outmain, so the fix must land there first.