fix(vercel): deploy landing/docs only on main when their files change#788
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
github-actions
Bot
added
bug
- landing reads apps/landing/vercel.json; docs (memry-docs) reads the root vercel.json because its Root Directory is the repo root. Both now skip preview (PR) deploys, and skip production deploys when their own files are unchanged, via ignoreCommand. - installCommand sets SKIP_ELECTRON_REBUILD=1 so the workspace install stops failing on desktop's better-sqlite3 electron-rebuild (broke at Electron 43). - Drop the '*' deploymentEnabled key: a literal branch name, not a wildcard, so it never disabled PR previews.
h4yfans
force-pushed
the
fix/vercel-deploy-conditions
branch
from
July 18, 2026 08:21
c7b394a to
3852e58
Compare
h4yfans
marked this pull request as ready for review
July 18, 2026 08:32
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ignoreCommandon landing + docs: skip preview (PR) deploys, and skip production deploys when that app's own files are unchanged.installCommandwithSKIP_ELECTRON_REBUILD=1: stop the workspace install failing on desktop's better-sqlite3 electron-rebuild."*"deploymentEnabledkey — it is a literal branch name, not a wildcard, so it never disabled PR previews.Why
Every merge to main redeployed landing/docs for unrelated desktop/sync changes, PR branches deployed failing previews, and every deploy since the Electron 43 bump (#765) errored on
pnpm install.