fix(devex): un-gate contracts vitest suite from root test pipeline - #816
Merged
Conversation
packages/contracts had 47 vitest files (1520+ tests incl. sync-payloads) but no 'test' script, so they never ran in 'pnpm test' or CI. All tests pass when run directly. Add 'test: vitest run' to packages/contracts/package.json (no new dep — vitest hoisted at root). Add --filter=@memry/contracts to root 'test' script for explicit first-class targeting, matching typecheck convention. Turbo's test task has dependsOn: ["^test"], so adding the leaf script alone auto-gates contracts via app-core dependency. The root filter is belt-and-suspenders.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
There was a problem hiding this comment.
Pull request overview
Ensures the @memry/contracts Vitest suite is executed as part of the workspace’s root pnpm test pipeline (so contracts tests aren’t silently skipped in CI/dev).
Changes:
- Add
test: "vitest run"script topackages/contracts. - Include
--filter=@memry/contractsin the roottestturbo invocation to explicitly target the contracts suite.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/contracts/package.json | Adds a test script so contracts’ Vitest suite is runnable via standard workspace scripts and turbo task discovery. |
| package.json | Updates the root test script to explicitly include @memry/contracts in the filtered turbo test run. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Contracts (47 vitest files, ~1520 tests incl. sync-payloads) had no
testscript, so the suite was skipped bypnpm testand CI despite always passing when run directly.Changes
packages/contracts/package.json: addtest: vitest runpackage.json: add--filter=@memry/contractsto roottestscriptvitest is hoisted at
node_modules/.bin/vitest— no new devDep. All 1523 tests pass.Non-obvious turbo behavior
The
testtask hasdependsOn: ["^test"]and app-core depends on @memry/contracts, so adding the leaf script alone auto-gates contracts via the dependency graph (turbo resolvescmd="vitest run"even without an explicit root filter). The root--filteris explicit first-class targeting, matching thetypecheckconvention.Testing
pnpm --filter @memry/contracts test→ 47 passed, 1523 tests passedReady for review and merge.