fix(inbox): don't fail task conversion when sync enqueue throws - #973
Merged
Conversation
convertToTask called syncTaskCreate unguarded after markItemAsFiled, so a sync enqueue failure aborted the conversion after the item was already filed and the task row committed — the caller saw a failure for a conversion that had actually happened. Mirror the convertToEvent guard: log, report to telemetry, and let dirty-recovery sweep the task later.
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
h4yfans
marked this pull request as ready for review
August 6, 2026 09:06
h4yfans
added a commit
that referenced
this pull request
Aug 6, 2026
Both sides added telemetry imports; keep #973's syncTaskCreate guard and this branch's task_created conversion event side by side.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Wrap
syncTaskCreateinconvertToTaskwith the same try/catch + telemetry guardconvertToEventalready uses, so a sync enqueue failure no longer reports an already-committed conversion as failed.Why
The item was already filed and the task row committed before the enqueue call; the throw only corrupted the caller's view (item filed, task local-only, reported as failure). Local task stays valid and dirty-recovery sweeps it later.