DEP-511 Disable logging when posting to trends-storage-server fails.#189
Merged
svanderburg merged 3 commits intomasterfrom Aug 17, 2018
Merged
DEP-511 Disable logging when posting to trends-storage-server fails.#189svanderburg merged 3 commits intomasterfrom
svanderburg merged 3 commits intomasterfrom
Conversation
Currently, customers end up with this message in their logs in cases where there is no data loss. This causes unnecessary confusion. We will replace this logging with grafana monitoring (DEP-87), and in the long run, we should also allow the buildpack to send exceptions that shouldn't be exposed to the customer via Sentry, so we can diagnose them.
Contributor
|
looks good! |
Contributor
|
alternatively change to |
joshp123
changed the title
Merged
joshp123
pushed a commit
that referenced
this pull request
Sep 25, 2018
We already made the changes in #189.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, customers end up with this message in their logs in cases
where there is no data loss. This causes unnecessary confusion.
We will replace this logging with grafana monitoring (DEP-87), and in
the long run, we should also allow the buildpack to send exceptions that
shouldn't be exposed to the customer via Sentry, so we can diagnose
them.