Re: DEP-463, DEP-511#196
Merged
joshp123 merged 4 commits intobuildpack-2.2from Sep 25, 2018
Merged
Conversation
hansthen
force-pushed
the
DEP-463
branch
2 times, most recently
from
373636d to
a622b35
Compare
Re: DEP-463 Add S3 storage metrics. This only works from a specific mendix version, which is why we have the catch-all handler. Re: DEP-511 Bandaid patcher to only print the first error message in case the logs storage server is unavailable.
joshp123
suggested changes
Sep 21, 2018
| "Failed to send metrics to trends server.", exc_info=True | ||
| ) | ||
| if self.logfailure: | ||
| logger.warning( |
Contributor
There was a problem hiding this comment.
We already did DEP-511 here: #189, so the changes to the logging are not needed.
| except Exception as e: | ||
| # We ignore errors here, as the information is not available for | ||
| # older mendix versions | ||
| logger.debug("METRICS: Error retrieving file sizes", e) |
Contributor
There was a problem hiding this comment.
Since we are only logging this at DEBUG level, then it would be good to include the traceback, replace e with exc_info=True.
added 2 commits
September 25, 2018 11:41
We already made the changes in #189.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: DEP-463 Add S3 storage metrics. This only works from a specific mendix
version, which is why we have the catch-all handler.
Re: DEP-511 Bandaid patcher to only print the first error message in case the logs
storage server is unavailable.