Skip to content

How to configure Json logging. - #8811

Merged
katarzyna-koltun-mx merged 1 commit into
mendix:developmentfrom
serg-firsov:how-to-enable-json-logging
Dec 23, 2024
Merged

How to configure Json logging.#8811
katarzyna-koltun-mx merged 1 commit into
mendix:developmentfrom
serg-firsov:how-to-enable-json-logging

Conversation

@serg-firsov

Copy link
Copy Markdown
Contributor

No description provided.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Sergey Firsov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@katarzyna-koltun-mx

Copy link
Copy Markdown
Collaborator

@serg-firsov Hi Sergey! I'll be reviewing your PR. I've noticed that there seem to be some extra } characters in some of the code blocks (lines 548, 574, 601, 602, 632). Could you verify?

Also, your github account doesn't have the Mendix CLA signed. Could you sign it?

@atennapel

Copy link
Copy Markdown
Contributor

Looks good to me, from a technical side.

@serg-firsov
serg-firsov force-pushed the how-to-enable-json-logging branch from 1a57465 to 9ffdad6 Compare December 23, 2024 12:39
@serg-firsov

serg-firsov commented Dec 23, 2024

Copy link
Copy Markdown
Contributor Author

Hi @katarzyna-koltun-mx,

@serg-firsov Hi Sergey! I'll be reviewing your PR. I've noticed that there seem to be some extra } characters in some of the code blocks (lines 548, 574, 601, 602, 632). Could you verify?

I didn't find extra } characters, but I noticed that I used single quotes while double quotes are used in the rest of the document, so I changed single quotes to double quotes to make it consistent.

Also, your github account doesn't have the Mendix CLA signed. Could you sign it?

I just did singn the Mendix CLA, but it still shows that it's not signed.

@katarzyna-koltun-mx

Copy link
Copy Markdown
Collaborator

@serg-firsov Thank you! I'll merge your PR now.

@katarzyna-koltun-mx
katarzyna-koltun-mx merged commit aed96ac into mendix:development Dec 23, 2024
@serg-firsov
serg-firsov deleted the how-to-enable-json-logging branch December 23, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants