Skip to content

Replace Images with code blocks for datastorage API how to (#8518) - #8843

Merged
MarkvanMents merged 7 commits into
developmentfrom
MvM-datastorageAPI
Jan 8, 2025
Merged

Replace Images with code blocks for datastorage API how to (#8518)#8843
MarkvanMents merged 7 commits into
developmentfrom
MvM-datastorageAPI

Conversation

@MarkvanMents

@MarkvanMents MarkvanMents commented Jan 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

See issue #8518
(Examples don't seem to be wrong - they have the right numbers of parameters)

@MarkvanMents MarkvanMents self-assigned this Jan 2, 2025
@MarkvanMents MarkvanMents changed the title MvM-datastorageAPI Replace Images with code blocks for datastorage API how to (#8518) Jan 2, 2025
dahfjkg
dahfjkg reviewed Jan 3, 2025
View reviewed changes
Comment thread content/en/docs/howto/extensibility/howto-datastorage-api.md
Comment thread content/en/docs/howto/extensibility/howto-datastorage-api.md
Comment thread content/en/docs/howto/extensibility/howto-datastorage-api.md Outdated
Comment thread content/en/docs/howto/extensibility/howto-datastorage-api.md Outdated
Comment thread content/en/docs/howto/extensibility/howto-datastorage-api.md Outdated
MarkvanMents
MarkvanMents commented Jan 3, 2025
View reviewed changes

@MarkvanMents MarkvanMents left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Pavel @dahfjkg
I've copied and pasted the correct code (wish I'd known it was there, would have saved me an hour or so) and tried to get the indentation correct.
I also did a quick proofread of the doc as it seems like it hasn't been looked at in a long time. (I need to come back to it when I have more time as there is lots of information hidden in the images which needs to be in the (alt) text.

I have just one question about the status of SQL calling in the Runtime API - the doc says it is in beta, is this still the case?

Otherwise, I think it is OK from my side. Is there anything else I need to do before I merge?

Thanks for all your help on this.

Comment thread content/en/docs/howto/extensibility/howto-datastorage-api.md Outdated
@dahfjkg

dahfjkg commented Jan 7, 2025

Copy link
Copy Markdown
Contributor

Passed technical review

@MarkvanMents

MarkvanMents commented Jan 8, 2025

Copy link
Copy Markdown
Collaborator Author

Thanks for the approval. Merging.

@MarkvanMents
MarkvanMents merged commit c45b657 into development Jan 8, 2025
@MarkvanMents MarkvanMents mentioned this pull request Jan 8, 2025
Closed
@MarkvanMents
MarkvanMents deleted the MvM-datastorageAPI branch January 8, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@dahfjkg dahfjkg dahfjkg left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@MarkvanMents MarkvanMents

Labels

Internal WIP Needs R&D technical verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MarkvanMents @dahfjkg