You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
⚠️ Approved with suggestions — low-severity items only, safe to merge
What was reviewed
File
Change
AGENTS.md
Clarified that changelogs are required for widgets/modules only, not shared packages
automation/utils/bin/rui-check-changelogs.ts
Reworked to simulate a 3-way merge via git merge-tree --write-tree before checking CHANGELOG validity; now also detects conflict markers
packages/shared/*/package.json (×13)
Added "private": true to all shared packages; one also gained "license": "Apache-2.0"
Skipped (out of scope): pnpm-lock.yaml, dist/
Findings
⚠️ Low — hasConflictMarkers only checks two of the three conflict-marker patterns
File:automation/utils/bin/rui-check-changelogs.ts line 121 Note: The helper checks for <<<<<<< and >>>>>>> but not for =======, the separator between conflicting hunks. A file that has the separator without the surrounding markers (edge case, but possible with custom merge drivers) would slip through. More importantly, omitting the check for ======= is slightly asymmetric. No blocking risk for the current use-case, but worth aligning:
⚠️ Low — git merge-tree --write-tree is Git ≥2.38; minimum Git version is not documented
File:automation/utils/bin/rui-check-changelogs.ts line 79 Note: The --write-tree flag was introduced in Git 2.38 (Oct 2022). If any CI runner or developer machine has an older Git, the script will fail with a confusing error. Consider adding a version check at the top of main(), or documenting the minimum Git version requirement in a comment.
Positives
The shift from git diff base...head (three-dot, symmetric diff) to a simulated merge tree is the correct approach for a changelog guard — it catches the real conflict scenario (both sides touched the same file) rather than just "this file was changed in the PR."
Marking all packages/shared/* packages as "private": true directly enforces the updated AGENTS.md rule that shared packages don't need changelogs — a clean policy-meets-tooling alignment.
Conflict-marker detection is a nice defensive addition; previously a CHANGELOG with unresolved markers would have silently passed parsing.
AGENTS.md update is concise and accurate — the single line change precisely captures the new rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.