fix(image-web): use icon size in structure preview - #2374
Conversation
Size the Structure mode placeholder using iconSize when the Image widget data source is an icon. Refs mendix#2373
|
Hello maker! Thank you for opening a pull request to the A small note from the maintainers: We know that you probably wish to see your cool new feature or fix ASAP, but bringing a new feature to the widget is a small journey. But don't be scared! We just need time to triage, test, and analyze this feature or fix. We may request XML, code, or other changes that may be needed to match our desired look and feel for the new feature. We, as maintainers, strive to make sure that every change made in the code doesn't break existing behavior. For now, here is what will happen next: IMPORTANT: This repository uses code checks (linters, tests, etc.). Someone from our team will trigger these checks for your PR. In short, we will not proceed with your PR until all checks are green. It's the PR owner's goal to make checks green; maintainers are not going to do it for you.
|
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
The Image widget applies image dimension logic to icon sources in Studio Pro's Structure mode. When height is set to automatic, the default
maxHeightof 250px is used for the placeholder, causing small icons to occupy 250px vertically.This change preserves the existing placeholder but uses the configured
iconSizefor both its width and height when the data source is set to Icon.Design mode and runtime rendering are unaffected.
Fixes #2373
What should be covered while testing?