fix(security): sanitize clear-text logging in triage, scraper, git_ops - #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses CodeQL rule
py/clear-text-logging-sensitive-dataacross 3 components:src/jobgitops/cli/triage.py: Omit rawapply_urlparameter logging when URL validation fails to avoid logging sensitive query strings or unsafe inputs (JobGitOps-cgp).src/jobgitops/scraper.py: Log character length ofissue_bodyin dry run mode instead of printing raw content snippet (JobGitOps-csc).src/jobgitops/git_ops.py: Applyredact_sensitive_stringtooriginal_errorin_push_with_lease_retryto prevent accidental token/credential leakage (JobGitOps-dz3).Verification
just validatepassed (all 542 unit tests, linter, formatting checks, and 95.25% test coverage).JobGitOps-cgp,JobGitOps-csc,JobGitOps-dz3.