Skip to content

Conversation

@merefield
Copy link
Owner

No description provided.

@angusmcleod angusmcleod self-requested a review November 21, 2022 08:45
@angusmcleod
Copy link
Collaborator

angusmcleod commented Nov 21, 2022

@merefield Looks good, albeit in my PR I didn't do the conversion to modern components yet as I'll be doing that in batch when I integrated the events integration plugin.

@merefield merefield marked this pull request as draft November 21, 2022 08:53
@merefield merefield changed the title FIX: convert d-button to modern component inc closure actions COMPATBILITY: resolve issues with old style actions whilst updating affected files to modern standards Nov 21, 2022
@merefield merefield marked this pull request as ready for review November 21, 2022 11:00
@angusmcleod
Copy link
Collaborator

@merefield Country selection doesn't seem to be working?

Screenshot 2022-11-21 at 12 17 44

@merefield merefield marked this pull request as draft November 21, 2022 11:20
@merefield
Copy link
Owner Author

merefield commented Nov 21, 2022

Ha, good catch, actually was already looking at that and had reverted to draft. Investigating

It's not a completely trivial issue, its related to:

Deprecation notice: Implicit mutation has been deprecated, please use `onChange` handler [deprecated since Discourse v2.4.0] [removal in Discourse 2.9.0.beta1] [deprecation id: discourse.select-kit]

@merefield merefield marked this pull request as ready for review November 21, 2022 13:08
@merefield
Copy link
Owner Author

ok that (and other issues I found) should be resolved.

@angusmcleod
Copy link
Collaborator

@merefield Looks good!

@angusmcleod angusmcleod merged commit eb9016e into main Nov 21, 2022
@angusmcleod angusmcleod deleted the compatibility_fixes branch November 21, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants