Introduce separate requirements-build.txt#242
Merged
Conversation
This is needed because we are instructing our users to build with `pip install --no-build-isolation` which tells pip to build in the current python env and ignores the build dependencies specified in pyproject.toml. Following the installation instructions for Firedrake release however, this environment may not have these build requirements installed already (notably Cython and a sufficiently new setuptools). Therefore we need to instruct users to run `pip install -r animate/requirements-build.txt` beforehand. TODO (after merge): * update wiki installation instructions * use the additional step in the CI
joewallwork
approved these changes
Jun 12, 2026
stephankramer
added a commit
that referenced
this pull request
Jun 13, 2026
This reverts commit 6c14106.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #241, see description there
Doing this before merging main into release (see #239) because I first want to fix the building of the firedrake-parmmg:release container which needs the additional requirements-build.txt step. After adding the step in "docs", it should then build again, but the animate tests will fail, which I will then address in #239.
Note that this merge has cherry-picked the commit from #241, which is not normally what we want to do as we end up with the same commit twice after merging main into release but I will deal with that in #239.